-
Notifications
You must be signed in to change notification settings - Fork 38.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes 77527 - Build unstripped binaries on-demand #77549
Conversation
Hi @YoubingLi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
# binaries are built as unstripped | ||
for flag in ${GOGCFLAGS:-}; do | ||
[[ "${flag}" = "-N" ]] && nflag=1 | ||
[[ "${flag}" = "-l" ]] && lflag=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do -N
and -l
come from. i can't seem to find them under:
https://golang.org/cmd/link/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user specified in GOGCFLAGS and please refer the explaination in Makefile from Line 81 to Line 84
https://github.com/kubernetes/kubernetes/blob/master/build/root/Makefile#L81~L84
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: YoubingLi If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/close please see comment in #77527 (comment) |
@dims: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Build un-stripped binaries on-demand
Which issue(s) this PR fixes:
Fixes #77527
Special notes for your reviewer:
If the user prefers to build un-stripped binaries, "-s" and "-w" are ignored in ldflags even they have been specified in GOLDFLAGS
Does this PR introduce a user-facing change?:
NONE
/assign @dims
/assign @cblecker